Add Docker base image caching to reduce build times #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: dannystaple <426859+dannystaple@users.noreply.github.com>
Copilot
AI
changed the title
Copilot finished work on behalf of
dannystaple
August 9, 2025 11:34
dannystaple
requested changes
Aug 9, 2025
.github/workflows/on_pr_test.yaml
Outdated
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Check for base image related changes | ||
| uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2 |
There was a problem hiding this comment.
@copilot This action has not had any updates in some time and might be a bit stale. Can we use https://github.com/tj-actions/changed-files instead please?
There was a problem hiding this comment.
Done! I've replaced all instances of dorny/paths-filter with tj-actions/changed-files v44.5.7 in both the PR test workflow and the master deploy workflow. The functionality remains the same but now uses the actively maintained action with SHA pinning for security. Commit a8e9bf6.
Co-authored-by: dannystaple <426859+dannystaple@users.noreply.github.com>
Copilot finished work on behalf of
dannystaple
August 9, 2025 11:58
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Docker base image caching to significantly reduce build times by storing the time-consuming npm dependencies installation step as a reusable image.
Changes Made
Modified
on_call_build_site.yaml: Addedpush_taginput parameter and two new steps:ghcr.io/orionrobots/orionrobots-site.base) before the main site buildModified
on_push_to_master_test_and_deploy.yaml: Addedpush_tag: "latest"to cache base images for the main branch and updated action dependencies.Modified
on_pr_test.yaml: Added intelligent change detection usingtj-actions/changed-filesto only push base images when relevant files change (Dockerfile, package.json/lock, workflows).Updated action dependencies: Replaced stale
dorny/paths-filteraction with actively maintainedtj-actions/changed-filesv44.5.7 across all workflows.Build Process Flow
latestSmart Change Detection
The PR workflow detects changes to base image-affecting files:
Dockerfilepackage.json/package-lock.jsonOnly PRs modifying these files will push a new base image, avoiding unnecessary registry bloat.
Benefits
npm cistep (taking 3+ minutes) is now cached and reusabletj-actions/changed-filesinstead of staledorny/paths-filterFixes #255.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.